Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stateless validator topology spread constraints #18

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

a-thomas-22
Copy link
Collaborator

@a-thomas-22 a-thomas-22 commented Feb 5, 2024

This fixes a few issues:

  • Service not properly selecting the right pods since it wasn't granular enough with selectors
  • Topology spread constraints and pdbs not properly selecting the appropriate sts

@a-thomas-22 a-thomas-22 marked this pull request as ready for review February 5, 2024 20:51
@a-thomas-22 a-thomas-22 requested review from lambchr and gmas February 5, 2024 20:51
Copy link
Contributor

@lambchr lambchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a-thomas-22 a-thomas-22 enabled auto-merge (squash) February 7, 2024 15:52
@a-thomas-22 a-thomas-22 disabled auto-merge February 7, 2024 15:52
@a-thomas-22 a-thomas-22 merged commit 6c1391e into main Feb 7, 2024
2 checks passed
@a-thomas-22 a-thomas-22 deleted the at/nitro-topology-spread-constraint-fix branch February 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants